Fixes to SLAB vertical jet#62
Merged
Merged
Conversation
SLAB VerticalJet was missing keyword arguments for averaging time and max downwind distance
Added unit test to confirm entire integration. Existing ones merely checked that the slab submodule worked, not that the interface with the rest of GasDispersion worked correctly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 95.51% 96.09% +0.58%
==========================================
Files 41 43 +2
Lines 2696 2866 +170
==========================================
+ Hits 2575 2754 +179
+ Misses 121 112 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SLAB transitions from steady state to transient it is possible to have two rows out of order, i.e. it appears to step backwards in time momentarily. In the past DataInterpolations would warn about this, but since v8.0.1 it breaks. This fixes the issue for a VerticalJet release type.
Also added some missing integration tests for the SLAB VerticalJet.